[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Core/DebuggerEvents.h:48-49
+  }
+  const std::string &GetTitle() const { return m_title; }
+  const std::string &GetUpdate() const { return m_update; }
   bool IsDebuggerSpecific() const { return m_debugger_specific; }
----------------
kastiglione wrote:
> Are these going to be needed in a follow up?
Yes, they're going in the dict from D143690. I saw Ismail's comments while working on this patch so I knew I was going to change it. 


================
Comment at: lldb/include/lldb/Core/DebuggerEvents.h:54
+  std::string m_title;
+  std::string m_update;
   const uint64_t m_id;
----------------
kastiglione wrote:
> minor quibble, but maybe `m_current_subtitle` (or some other `m_current_<noun>`) – I know that's wordy but "update" is a bit vague. Do as you please tho.
How about `m_details`. I don't think we need to include current here, as this is all part of a single event. I'll add comments to set expectations about the title being fixed and the details potentially changing. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143690/new/

https://reviews.llvm.org/D143690