[Lldb-commits] [lldb] 49470f1 - Remove test case that tries to allocate impossible amounts

[Jason Molenda via lldb-commits]

Author: Jason Molenda
Date: 2023-02-09T10:44:40-08:00
New Revision: 49470f1eacca6aa5ab0f860347aa282a79323161

URL: https://github.com/llvm/llvm-project/commit/49470f1eacca6aa5ab0f860347aa282a79323161
DIFF: https://github.com/llvm/llvm-project/commit/49470f1eacca6aa5ab0f860347aa282a79323161.diff

LOG: Remove test case that tries to allocate impossible amounts

The sanitizer bots are failing with this test; they
impose a maximum 0x10000000000 size on allocations, and
malloc on darwin will let me malloc that much.  The
alternative to keep this would be to break it out into a
seperate test in TestProcessAIP and skip that if it's on
the sanitizer, but this is seeming too fragile IMO so I'm
punting it entirely.

Added: 
    

Modified: 
    lldb/test/API/python_api/process/TestProcessAPI.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/python_api/process/TestProcessAPI.py b/lldb/test/API/python_api/process/TestProcessAPI.py
index afcc9d7cdee0d..c56053dad0cf1 100644
--- a/lldb/test/API/python_api/process/TestProcessAPI.py
+++ b/lldb/test/API/python_api/process/TestProcessAPI.py
@@ -73,22 +73,6 @@ def test_read_memory(self):
             exe=False,
             startstr=b'x')
 
-        if self.platformIsDarwin():
-          # Try to read an impossibly large amount of memory; swig
-          # will try to malloc it and fail, we should get an error 
-          # result.
-          error = lldb.SBError()
-          bigsize = sys.maxsize - 8;
-          content = process.ReadMemory(
-                  val.AddressOf().GetValueAsUnsigned(), 
-                  bigsize, error)
-          if error.Success():
-              self.assertFalse(error.Success(), "SBProcessReadMemory claims to have "
-                        "successfully read 0x%x bytes" % bigsize)
-          if self.TraceOn():
-              print("Tried to read 0x%x bytes, got error message: %s" %
-                    (bigsize, error.GetCString()))
-
         # Read (char *)my_char_ptr.
         val = frame.FindValue("my_char_ptr", lldb.eValueTypeVariableGlobal)
         self.DebugSBValue(val)