[Lldb-commits] [PATCH] D143215: lldb can know architecture-dependent watchpoint behaviors, instead of depending on the remote stub

David Spickett via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 9 01:22:33 PST 2023


DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

One minor comment otherwise LGTM.

`[LLDB]` tag in the commit title please :)



================
Comment at: lldb/source/Target/Process.cpp:2371
+  if (triple.isAArch64() || triple.isArmMClass() || triple.isARM())
+    reported_after = false;
+
----------------
Combine these into one and if you feel like it, `return false` instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143215/new/

https://reviews.llvm.org/D143215



More information about the lldb-commits mailing list