[Lldb-commits] [PATCH] D143215: lldb can know architecture-dependent watchpoint behaviors, instead of depending on the remote stub

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 8 16:02:56 PST 2023


jasonmolenda updated this revision to Diff 495976.
jasonmolenda retitled this revision from "Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information" to "lldb can know architecture-dependent watchpoint behaviors, instead of depending on the remote stub".
jasonmolenda edited the summary of this revision.
jasonmolenda added a comment.
Herald added subscribers: pcwang-thead, s.egerton, simoncook.

Update to fix David's second round of comments, rewrite the Title/Summary to more accurately reflect what I'm doing in this patch.  I think we're about done here, but open to any comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143215/new/

https://reviews.llvm.org/D143215

Files:
  lldb/include/lldb/Target/Process.h
  lldb/source/API/SBProcess.cpp
  lldb/source/Commands/CommandObjectWatchpoint.cpp
  lldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
  lldb/source/Plugins/Process/Windows/Common/ProcessWindows.h
  lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
  lldb/source/Target/Process.cpp
  lldb/source/Target/StopInfo.cpp
  lldb/source/Target/Target.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D143215.495976.patch
Type: text/x-patch
Size: 16492 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230209/133e5c7b/attachment-0001.bin>


More information about the lldb-commits mailing list