[Lldb-commits] [PATCH] D143623: [lldb] Print an error for unsupported combinations of log options

[Alex Langford via Phabricator via lldb-commits]

bulbazord requested changes to this revision.
bulbazord added inline comments.
This revision now requires changes to proceed.


================
Comment at: lldb/source/Commands/CommandObjectLog.cpp:180-184
+    if ((m_options.handler != eLogHandlerCircular &&
+         m_options.handler != eLogHandlerStream) &&
+        m_options.buffer_size.GetCurrentValue() != 0) {
+      result.AppendError("a buffer size can only be specified for the circular "
+                         "buffer handler.\n");
----------------



================
Comment at: lldb/test/Shell/Log/TestHandlers.test:5
+# UNSUPPORTED-FILE: a file name can only be specified for the stream handler
+# UNSUPPORTED-BUFFER:  a buffer size can only be specified for the circular buffer handler
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143623/new/

https://reviews.llvm.org/D143623