[Lldb-commits] [PATCH] D143548: [lldb] Add the ability to remove diagnostic callbacks

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D143548#4113687 <https://reviews.llvm.org/D143548#4113687>, @mib wrote:

> LGTM! Is there a simple way to test this ?

I considered a unit test, but that would require making everything protected and would basically boil down to testing the implementation of the underlying container, but I can add it if you think it's worthwhile. I think a better way to test this is through an integration test that exercises this code path. D143548 <https://reviews.llvm.org/D143548> would indirectly test it (it doesn't crash but I assume ASAN would have caught it).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143548/new/

https://reviews.llvm.org/D143548