[Lldb-commits] [PATCH] D143548: [lldb] Add the ability to remove diagnostic callbacks

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 8 12:20:11 PST 2023


mib added a comment.

LGTM! Is there a simple way to test this ?



================
Comment at: lldb/source/Utility/Diagnostics.cpp:55-58
+  m_callbacks.erase(
+      std::remove_if(m_callbacks.begin(), m_callbacks.end(),
+                     [id](const CallbackEntry &e) { return e.id == id; }),
+      m_callbacks.end());
----------------
nit: may be use `llvm::remove_if` instead ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143548/new/

https://reviews.llvm.org/D143548



More information about the lldb-commits mailing list