[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 13 16:24:47 PST 2023


mib updated this revision to Diff 489151.
mib marked an inline comment as not done.
mib added a comment.

Address @JDevlieghere comment:

- Check is stdout is a tty to run in interactive mode
- Remove extra return line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141658/new/

https://reviews.llvm.org/D141658

Files:
  lldb/examples/python/crashlog.py
  lldb/test/Shell/ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
  lldb/test/Shell/ScriptInterpreter/Python/Crashlog/interactive_crashlog_invalid_target.test
  lldb/test/Shell/ScriptInterpreter/Python/Crashlog/json.test
  lldb/test/Shell/ScriptInterpreter/Python/Crashlog/no_threadState.test
  lldb/test/Shell/ScriptInterpreter/Python/Crashlog/scripted_crashlog_json.test
  lldb/test/Shell/ScriptInterpreter/Python/Crashlog/skipped_status_interactive_crashlog.test
  lldb/test/Shell/ScriptInterpreter/Python/Crashlog/text.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141658.489151.patch
Type: text/x-patch
Size: 9109 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230114/7a8b596d/attachment.bin>


More information about the lldb-commits mailing list