[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM. You can remove one of the `-b` in the test to check the TTY stuff (it should be false when piping into FileCheck).



================
Comment at: lldb/examples/python/crashlog.py:1302
+        print("Aborting symbolication.")
+        print()
+        option_parser.print_help()
----------------
mib wrote:
> JDevlieghere wrote:
> > Spurious print? It doesn't look like we're printing a double newline elsewhere.
> I wanted to leave space between the actual error message and the help
I like this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141658/new/

https://reviews.llvm.org/D141658