[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:1302
+        print("Aborting symbolication.")
+        print()
+        option_parser.print_help()
----------------
JDevlieghere wrote:
> Spurious print? It doesn't look like we're printing a double newline elsewhere.
I wanted to leave space between the actual error message and the help


================
Comment at: lldb/examples/python/crashlog.py:452
 
-        with open(path, 'r', encoding='utf-8') as f:
+        with open(os.path.normpath(os.path.expanduser(path)), 'r', encoding='utf-8') as f:
             buffer = f.read()
----------------
JDevlieghere wrote:
> It's not obvious why this is necessary (and we can't rely on open/the OS to do this for us) so let's add a comment. 
>From my experience, `open`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141658/new/

https://reviews.llvm.org/D141658