[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

This seems very intrusive: I don't think every plugin should have to be aware of this metadata that only one plugin needs. Is there a way to avoid this? For example, could we initialize a generic scripted platform first, with no backing Python class, and then have that set after the fact? My concern here is how the scripted process/platform is slowly creeping into all the generic code. Maybe that will require bigger design changes or maybe it's entirely unavoidable to achieve what we need, but I'd like to make sure we've given fair consideration to potential alternatives.

(Requesting changes so this shows up in my review queue)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139249/new/

https://reviews.llvm.org/D139249