[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

I haven't followed the lldb-vscode codebase closely enough to have useful comments on that part of the code.

But so far as I can tell, you didn't add a test for SBTarget::GetMaximumOpcodeByteSize, so you should add that before this goes in.  Maybe it was folded into the lldb-vscode tests and I missed it, but even so this should have a direct test, not I don't think we should require people to build lldb-vscode to test general features of lldb.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140358/new/

https://reviews.llvm.org/D140358