[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

[Arthur Eubanks via Phabricator via lldb-commits]

aeubanks added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2521
+    if (name_bracket_index == llvm::StringRef::npos &&
+        matching_type->IsTemplateType())
+      return true;
----------------
Michael137 wrote:
> You could consider using `CompilerType::GetTypeInfo` instead of introducing `CompilerType::IsTemplateType`. Though that function looks a bit chunky
just tried this but it's recognizing the type as just a normal record instead of a template instantiation


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140240/new/

https://reviews.llvm.org/D140240