[Lldb-commits] [PATCH] D140240: [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

Michael Buch via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Dec 20 07:20:21 PST 2022


Michael137 added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2521
+    if (name_bracket_index == llvm::StringRef::npos &&
+        matching_type->IsTemplateType())
+      return true;
----------------
You could consider using `CompilerType::GetTypeInfo` instead of introducing `CompilerType::IsTemplateType`. Though that function looks a bit chunky


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140240/new/

https://reviews.llvm.org/D140240



More information about the lldb-commits mailing list