[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

Wed Nov 16 15:09:48 PST 2022

aprantl added inline comments.

================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:13
 #include "lldb/Host/macosx/HostInfoMacOSX.h"
+#include "lldb/Core/Debugger.h"
 #include "lldb/Utility/Args.h"
----------------
labath wrote:
> We shouldn't have Host->Core dependencies. Could you report the error in the caller?
How strong to you fell about this?
It would be an odd interface. `GetXcodeSDKPath` also caches negative results because negative lookups are really slow. This means we would only raise an error on the first call and not on the subsequent ones. I can do that, but it also feels weird. I guess we could cache the error string as well?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138060/new/

https://reviews.llvm.org/D138060