[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:410
+      LLDB_LOG(log, "xcrun returned exit code %d", status);
+      return "";
+    }
----------------
JDevlieghere wrote:
> Why not return an Error?
For the caller of this lambda "there is no such SDK" is not an error that should be surfaced to the user. There's a loop that will try multiple alternate spellings until it finds a matching SDK.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138060/new/

https://reviews.llvm.org/D138060