[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

Sun Oct 23 01:29:18 PDT 2022

hawkinsw added inline comments.

================
Comment at: lldb/source/Core/ValueObject.cpp:1947
-  // name ([%d]) to the expression path
-  if (m_flags.m_is_array_item_for_pointer &&
-      epformat == eGetExpressionPathFormatHonorPointers)
----------------
I am *absolutely* not an expert here but I've spent several hours trying to debug why this incredibly thorough, well-written patch does not handle the case in `TestArray.py`. It would seem to me that this is the check that we forgot to bring over in to the new logic. I was attempting to be able to have an updated version of the patch by tonight, but didn't get further than just debugging. I will continue to work on it -- I am sure that you gurus have other, more important things to work on. 

That said, I am just trying to help so if I am totally off base, please let me know!

Sincerely,
Will

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132734/new/

https://reviews.llvm.org/D132734