[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

[Emmmer S via Phabricator via lldb-commits]

Emmmer updated this revision to Diff 447322.
Emmmer added a comment.

> Why is this only needed for PECOFF? (maybe it is the only one that lists them like this)

At first, I tracked a bug from `LLDBServerTests` and thought that `GetArchitecture()` returned a wrong match, so I added `case llvm::COFF::IMAGE_FILE_MACHINE_RISCV64` to the function (there is indeed an `IMAGE_FILE_MACHINE_RISCV64` in `COFF.h`, so I regarded it was a global architecture judgment ).

Later, I found out that `HostInfoBase.cpp` did not add a match to `riscv64`, and it ran as expected after adding it.

I forgot to delete it in my local repo, sorry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130342/new/

https://reviews.llvm.org/D130342

Files:
  lldb/source/Host/common/HostInfoBase.cpp
  lldb/source/Plugins/Process/Linux/CMakeLists.txt
  lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.cpp
  lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.h
  lldb/source/Plugins/Process/Utility/CMakeLists.txt
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_riscv64.cpp
  lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_riscv64.h
  lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_riscv64.cpp
  lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_riscv64.h
  lldb/source/Plugins/Process/Utility/RegisterInfos_riscv64.h
  lldb/source/Utility/ArchSpec.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D130342.447322.patch
Type: text/x-patch
Size: 37074 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220725/ac18c083/attachment-0001.bin>