[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:1347
   case llvm::COFF::IMAGE_FILE_MACHINE_ARM64:
+  case llvm::COFF::IMAGE_FILE_MACHINE_RISCV64:
     ArchSpec arch;
----------------
Why is this only needed for PECOFF? (maybe it is the only one that lists them like this)


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_riscv64.cpp:24
+// they define some macros which collide with variable names in other modules
+#include <sys/socket.h>
+// NT_PRSTATUS and NT_FPREGSET definition
----------------
This can be `sys/uio.h` I'm pretty sure.

I know the other NativeRegisterContexts include socket.h but I'm looking at changing those.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130342/new/

https://reviews.llvm.org/D130342