[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

[Louis Dionne via Phabricator via lldb-commits]

ldionne added inline comments.


================
Comment at: llvm/CMakeLists.txt:441
 
+set(LLVM_ENABLE_ZSTD "ON" CACHE STRING "Use zstd for compression/decompression if available. Can be ON, OFF, or FORCE_ON")
+
----------------
This broke builds that do not specify `LLVM_ENABLE_ZSTD=OFF` explicitly on macOS, and I suspect on other platforms as well:

```
ld: library not found for -lzstd
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

It looks to me like the build should not require `zstd` to be installed by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128465/new/

https://reviews.llvm.org/D128465