[Lldb-commits] [PATCH] D129272: [lldb][Windows] Fix memory region base addresses when a range is split

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:119
+                    or (region_end > previous_base and region_end <= previous_end):
+                    self.assertFalse(base_address in base_addresses,
+                        "Unexpected overlapping memory region found.")
----------------
labath wrote:
> I don't see `base_addresses` defined anywhere. I guess this should just be `assertFalse`, and the overlap condition right?
> 
> Btw, can [[ https://stackoverflow.com/questions/3269434/whats-the-most-efficient-way-to-test-if-two-ranges-overlap | check for overlap ]] with `region_base < previous_end && previous_base < region_end`.
Completely missed that yes, I'll fix it up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129272/new/

https://reviews.llvm.org/D129272