[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: lldb/source/Commands/CommandObjectProcess.cpp:582
       }
-      
+
       Target *target = m_exe_ctx.GetTargetPtr();
----------------
many formatting changes sneaked in. The actual changes are in the end of this file


================
Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleSaver.cpp:241
+    if (std::error_code ec =
+            llvm::sys::fs::copy_file(file, path_to_copy_module.GetPath()))
       return createStringError(
----------------
this was a bug in the existing code that prevented copying a module that was loaded from a bundle


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129239/new/

https://reviews.llvm.org/D129239