[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added subscribers: labrinea, DavidSpickett.
DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added a comment.
Herald added a subscriber: Michael137.

> conflicting instructions with the same encoding in different extensions, but it doesn't seem possible within one archeticture

I seem to remember some system register names changing between architecture *profiles* not version. @labrinea may know more about that.

> Well, it broke a lot of tests that were checking that instructions are not disassembled without explicitly specified extensions, but i don't quite get the point of such tests.

Without looking at them in detail I assume they are checking that the proper extension name is printed when it says "requires bla" and that each instruction is properly tied to the correct feature name. This is for when you are assembling as opposed to disassembling.

I agree that objdump should have some kind of "max" setting, even a default. However there will still need to be a way to test what I referred to.

What might be possible is to write the testing such that it doesn't use llvm-objdump. I haven't seen the structure of the tests perhaps this would mean duplicating tests all over the place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127741/new/

https://reviews.llvm.org/D127741