[Lldb-commits] [PATCH] D127937: [lldb] Add RotatingLogHandler

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/unittests/Utility/LogTest.cpp:112
+  handler.Dump(stream);
+  return stream.str();
+}
----------------
kastiglione wrote:
> minor: `return buffer;`
I did that on purpose to avoid the call to `flush` but looking at the `raw_string_ostream` the stream is unbuffered and `str` doesn't even call flush under the hood. TIL. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127937/new/

https://reviews.llvm.org/D127937