[Lldb-commits] [lldb] b97b082 - Fix failures

Walter Erquinigo via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 15 13:54:11 PDT 2022


Author: Walter Erquinigo
Date: 2022-06-15T13:54:04-07:00
New Revision: b97b082c5a0d2b1d8a4c18865408aad35844016e

URL: https://github.com/llvm/llvm-project/commit/b97b082c5a0d2b1d8a4c18865408aad35844016e
DIFF: https://github.com/llvm/llvm-project/commit/b97b082c5a0d2b1d8a4c18865408aad35844016e.diff

LOG: Fix failures

https://lab.llvm.org/buildbot/#/builders/17/builds/23269 breaks because
we are doing some asm calls that only work on x86

https://lab.llvm.org/buildbot/#/builders/68/builds/34092/steps/6/logs/stdio
breaks because some comparators where being done incorrectly.

Added: 
    

Modified: 
    lldb/unittests/Process/Linux/PerfTests.cpp
    lldb/unittests/Utility/TraceGDBRemotePacketsTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Process/Linux/PerfTests.cpp b/lldb/unittests/Process/Linux/PerfTests.cpp
index c12aa097dd3c..6332cd97676c 100644
--- a/lldb/unittests/Process/Linux/PerfTests.cpp
+++ b/lldb/unittests/Process/Linux/PerfTests.cpp
@@ -6,6 +6,8 @@
 //
 //===----------------------------------------------------------------------===//
 
+#ifdef __x86_64__
+
 #include "Perf.h"
 
 #include "llvm/Support/Error.h"
@@ -83,3 +85,5 @@ TEST(Perf, TscConversion) {
   ASSERT_LT(converted_tsc_
diff .count(),
             (SLEEP_NANOS + acceptable_overhead).count());
 }
+
+#endif // __x86_64__

diff  --git a/lldb/unittests/Utility/TraceGDBRemotePacketsTest.cpp b/lldb/unittests/Utility/TraceGDBRemotePacketsTest.cpp
index b3f8538ee8b6..47f55181ca38 100644
--- a/lldb/unittests/Utility/TraceGDBRemotePacketsTest.cpp
+++ b/lldb/unittests/Utility/TraceGDBRemotePacketsTest.cpp
@@ -94,7 +94,6 @@ TEST(TraceGDBRemotePacketsTest, IntelPTGetStateResponseEmpty) {
   // portions of the JSON representation are unchanged.
   ASSERT_EQ(toJSON(response), toJSON(*deserialized_response));
   // Ensure that the tsc_conversion's are nullptr.
-  ASSERT_EQ(response.tsc_perf_zero_conversion, None);
-  ASSERT_EQ(response.tsc_perf_zero_conversion,
-            deserialized_response->tsc_perf_zero_conversion);
+  ASSERT_FALSE((bool)response.tsc_perf_zero_conversion);
+  ASSERT_FALSE((bool)deserialized_response->tsc_perf_zero_conversion);
 }


        


More information about the lldb-commits mailing list