[Lldb-commits] [PATCH] D127804: [trace][intelpt] Support system-wide tracing [19] - Some other minor improvements

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 15 10:45:21 PDT 2022


wallace added inline comments.


================
Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.h:53
+///
+/// \param[in] decoded_thread
+///   All decoded instructions, errors and events will be appended to this object.
----------------
jj10306 wrote:
> isn't this really an out param?
you're too good


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127804/new/

https://reviews.llvm.org/D127804



More information about the lldb-commits mailing list