[Lldb-commits] [PATCH] D127881: [trace][intelpt] Support system-wide tracing [22] - Use a weak pointer to avoid using a pointer to the Trace

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 15 10:38:38 PDT 2022


wallace created this revision.
wallace added a reviewer: jj10306.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Having a member variable TraceIntelPT * makes it look as if it was
optional. I'm using instead a weak_ptr to indicate that it's not
optional and the object is under the ownership of TraceIntelPT.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D127881

Files:
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPTMultiCpuDecoder.cpp
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPTMultiCpuDecoder.h
  lldb/source/Plugins/Trace/intel-pt/TraceIntelPTSessionFileParser.cpp
  lldb/source/Plugins/Trace/intel-pt/forward-declarations.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127881.437241.patch
Type: text/x-patch
Size: 11493 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220615/60893586/attachment-0001.bin>


More information about the lldb-commits mailing list