[Lldb-commits] [PATCH] D127819: [trace][intelpt] Support system-wide tracing [21] - Support long numbers in JSON

Jakob Johnson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 15 10:15:23 PDT 2022


jj10306 accepted this revision.
jj10306 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Utility/TraceIntelPTGDBRemotePackets.cpp:25
 
+json::Value toJSON(const JSONUINT64 &uint64, bool hex) {
+  if (hex)
----------------
should there be an option to write it as an integer or would the user just be expected to use a raw u64 in that case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127819/new/

https://reviews.llvm.org/D127819



More information about the lldb-commits mailing list