[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

[Alvin Wong via Phabricator via lldb-commits]

alvinhochun added a comment.

Does this test look good:

  diff
  diff --git a/lldb/test/Shell/Commands/command-target-create-resolve-exe.test b/lldb/test/Shell/Commands/command-target-create-resolve-exe.test
  new file mode 100644
  index 000000000000..3dfa7f0d9853
  --- /dev/null
  +++ b/lldb/test/Shell/Commands/command-target-create-resolve-exe.test
  @@ -0,0 +1,22 @@
  +# REQUIRES: system-windows
  +# RUN: mkdir "%t.dir"
  +# RUN: %clang_host -g0 -O0 %S/Inputs/main.c -o %t.dir\testmain.exe
  +
  +## Test with full path to exe
  +# RUN: %lldb %t.dir\testmain.exe -b | FileCheck %s
  +
  +## Test with exe on path, with .exe suffix
  +# RUN: set "PATH=%t.dir;%%PATH%%" && %lldb testmain.exe -b | FileCheck %s
  +
  +## Test with exe on path, without .exe suffix
  +# RUN: set "PATH=%t.dir;%%PATH%%" && %lldb testmain -b | FileCheck %s
  +
  +## Test with in cwd, with .exe suffix
  +# RUN: cd "%t.dir" && %lldb testmain.exe -b | FileCheck %s
  +
  +## Test with in cwd, without .exe suffix
  +# RUN: cd "%t.dir" && %lldb testmain -b | FileCheck %s
  +
  +# LABEL: target create
  +# CHECK-NEXT: Current executable set to '{{.*[/\\]}}testmain.exe'
  +# CHECK-NOT: Error


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127436/new/

https://reviews.llvm.org/D127436