[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

Fri Jun 10 11:11:12 PDT 2022

alvinhochun added a comment.

I suppose it is possible to have a Windows-only test for this. (Someone will need to verify them for me though as I don't have a build that runs tests on Windows.)

This doesn't currently work with a path without the suffix though (like `C:\Windows\System32\notepad` would not work). `ResolveExecutableLocation` calls `llvm::sys::findProgramByName` (from `llvm/lib/Support/Windows/Program.inc`), which doesn't do anything if the argument is a path. I can change this behaviour, but it may affect more than just `target create`... I don't feel comfortable making this change here for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127436/new/

https://reviews.llvm.org/D127436