[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/source/Core/Debugger.cpp:1873-1875
+  if (message.size() + prefix_width + suffix_width >= term_width)
+    message.erase(message.begin() + term_width - prefix_width - suffix_width,
+                  message.end());
----------------
JDevlieghere wrote:
> Should this account for the control characters? Do they cause a line wrap?
In my understanding, if the control character is complete, it shouldn't print anything to the screen so they shouldn't cause a line wrap


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124785/new/

https://reviews.llvm.org/D124785