[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 2 11:46:33 PDT 2022


JDevlieghere added a comment.

Can we add a pexpect test for this?



================
Comment at: lldb/source/Core/Debugger.cpp:1873-1875
+  if (message.size() + prefix_width + suffix_width >= term_width)
+    message.erase(message.begin() + term_width - prefix_width - suffix_width,
+                  message.end());
----------------
Should this account for the control characters? Do they cause a line wrap?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124785/new/

https://reviews.llvm.org/D124785



More information about the lldb-commits mailing list