[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

[Fangrui Song via Phabricator via lldb-commits]

MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:315
+  uint32_t endian = header.e_ident[EI_DATA];
+  if(endian == ELFDATA2LSB)
+    return ArchSpec::eCore_ppc64le_generic;
----------------



================
Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:326
     return riscvVariantFromElfFlags(header);
+  else if (header.e_machine == llvm::ELF::EM_PPC64)
+    return ppc64VariantFromElfFlags(header);
----------------
Move before EM_RISCV for an alphabetical order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124760/new/

https://reviews.llvm.org/D124760