[Lldb-commits] [PATCH] D124061: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of order.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 20 02:13:50 PDT 2022


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

seems reasonable



================
Comment at: lldb/test/Shell/SymbolFile/NativePDB/local-variables-registers.s:247-248
 .Ltmp24:
-	.cv_def_range	 .Ltmp0 .Lfunc_end0, subfield_reg, 18, 0
-	.cv_def_range	 .Ltmp1 .Lfunc_end0, subfield_reg, 3, 4
+	.cv_def_range	 .Ltmp0 .Lfunc_end0, subfield_reg, 3, 4
+	.cv_def_range	 .Ltmp1 .Lfunc_end0, subfield_reg,18, 0
 	.short	2                               # Record length
----------------
Maybe add a comment about the order being deliberatele inverted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124061/new/

https://reviews.llvm.org/D124061



More information about the lldb-commits mailing list