[Lldb-commits] [PATCH] D124061: [LLDB][NativePDB] Fix the case when S_DEFRANGE_SUBFIELD_REGISTERs are out of order.

Zequan Wu via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 19 20:15:07 PDT 2022


zequanwu created this revision.
zequanwu added reviewers: rnk, labath.
Herald added a project: All.
zequanwu requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Previously, I was assuming that S_DEFRANGE_SUBFIELD_REGISTERs are always in the
increasing order of offset_in_parent until I saw a counter example.

Using `std::map` so that they are sorted by offset_in_parent.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124061

Files:
  lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp
  lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.h
  lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp
  lldb/test/Shell/SymbolFile/NativePDB/local-variables-registers.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124061.423800.patch
Type: text/x-patch
Size: 7823 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20220420/2e5a6224/attachment-0001.bin>


More information about the lldb-commits mailing list