[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 1 22:25:43 PDT 2022


shafik added inline comments.


================
Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp:236
   if (count)
-    m_name = ConstString((char *)buffer_sp->GetBytes());
+    m_name = ConstString((const char *)buffer_sp->GetBytes());
   else
----------------
nitpick `reinterpret_cast` instead of C-style cast.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122856/new/

https://reviews.llvm.org/D122856



More information about the lldb-commits mailing list