[Lldb-commits] [PATCH] D122867: [trace][intel pt] Handle better tsc in the decoder

Jakob Johnson via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 1 14:01:57 PDT 2022


jj10306 accepted this revision.
jj10306 added a comment.

Looks good



================
Comment at: lldb/source/Plugins/Trace/intel-pt/IntelPTDecoder.cpp:248
 
-  DecodeInstructions(*decoder, decoded_thread_sp);
+  DecodeInstructions(*decoder, *decoded_thread_sp.get());
   pt_insn_free_decoder(decoder);
----------------
Do you need .get() or does just `*decoded_thread` work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122867/new/

https://reviews.llvm.org/D122867



More information about the lldb-commits mailing list