[Lldb-commits] [PATCH] D122848: Reduce extraneous temp strings in debugserver, free objects when they're not longer needed

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

I was chatting with Jonas about this a bit.  The part of this patch which fixes all of the `SendPacket(outbuf.c_str())` calls, to avoid a temporary copy of the std::string, is clearly necessary and correct.  The changes to clear the ostringstreams eagerly after we've escaped the data is noisy, and I'll remove those and look at updating JSONGenerator to print escaped string representations directly, to eliminate the unescaped copy & the escaped copy duplication.  I'll update the patch in a bit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122848/new/

https://reviews.llvm.org/D122848