[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

Tue Mar 29 15:53:01 PDT 2022

JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.

In D122684#3415303 <https://reviews.llvm.org/D122684#3415303>, @clayborg wrote:

> So this will fix LLDB complaining when a binary contains arm64 and x86_64 when debugging on either platform? Great, we ran into this quite a bit lately!

Yes, exactly. The issue is was introduced by https://reviews.llvm.org/D113159. Previously, `IsHost()` would be false for `remote-macosx` and the `OSNAME` would expand to `ios` returning an absolutely bogus triples. But my change fixed that, causing the `remote-macosx` platform to be a real contender, and resulting in an error message:

  error: more than one platform supports this executable (host, remote-macosx), specify an architecture to disambiguate

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122684/new/

https://reviews.llvm.org/D122684