[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

[Med Ismail Bennani via Phabricator via lldb-commits]

mib marked 3 inline comments as done.
mib added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:990
+    res = lldb.SBCommandReturnObject()
+    ci.HandleCommand('script from lldb.macosx import crashlog_scripted_process', res)
+    if not res.Succeeded():
----------------
JDevlieghere wrote:
> mib wrote:
> > JDevlieghere wrote:
> > > Do we need to have LLDB import it? Can we import it here straight from python?
> > `crashlog.py` can be imported outside of the debugger, so in my understanding, if we're importing it here directly, lldb's script interpreter might not find the module and class used to create the ScriptedProcess object.
> But that's not relevant for the (new) interactive mode? If you run crashlog on the command line it should behave like it does today. 
It's actually only relevant for the new interactive mode, since this will import the crashlog scripted process blueprint. Otherwise, launching the process won't work (see line 999) because lldb won't find the managing class module.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119501/new/

https://reviews.llvm.org/D119501