[Lldb-commits] [PATCH] D119501: [lldb/crashlog] Add CrashLogScriptedProcess & remove interactive mode

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/examples/python/crashlog.py:990
+    res = lldb.SBCommandReturnObject()
+    ci.HandleCommand('script from lldb.macosx import crashlog_scripted_process', res)
+    if not res.Succeeded():
----------------
mib wrote:
> JDevlieghere wrote:
> > Do we need to have LLDB import it? Can we import it here straight from python?
> `crashlog.py` can be imported outside of the debugger, so in my understanding, if we're importing it here directly, lldb's script interpreter might not find the module and class used to create the ScriptedProcess object.
But that's not relevant for the (new) interactive mode? If you run crashlog on the command line it should behave like it does today. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119501/new/

https://reviews.llvm.org/D119501