[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

Thu Feb 10 11:43:06 PST 2022

clayborg accepted this revision.
clayborg added a comment.

In D119146#3310353 <https://reviews.llvm.org/D119146#3310353>, @labath wrote:

> Given the renewed interest in the size of the ConstString pool, I'd like to avoid adding strings there without a good reason. And I don't see any reason why a name-based platform lookup should be on any hot path. A Target object holds a platform pointer, the current platform is a pointer, and anything else that is hot enough should probably hold a pointer instead of a name as well.

As you mention there won't be many of these, so it won't take up much space in the string pool, but I am not adamant that this would need to change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119146/new/

https://reviews.llvm.org/D119146