[Lldb-commits] [lldb] d63dfa1 - [lldb] Update outdated comment in TestDyldTrieSymbols.py

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 7 08:14:00 PST 2022


Author: Jonas Devlieghere
Date: 2022-02-07T08:13:54-08:00
New Revision: d63dfa14d629efe9d85de07abeae7b58a76d52cd

URL: https://github.com/llvm/llvm-project/commit/d63dfa14d629efe9d85de07abeae7b58a76d52cd
DIFF: https://github.com/llvm/llvm-project/commit/d63dfa14d629efe9d85de07abeae7b58a76d52cd.diff

LOG: [lldb] Update outdated comment in TestDyldTrieSymbols.py

After aed965d55d46 we no longer demangle and store the full name. The
test was updated accordingly but the comment still specified that we
should be able to find the symbol by its full demangled name.

Added: 
    

Modified: 
    lldb/test/API/macosx/dyld-trie-symbols/TestDyldTrieSymbols.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/macosx/dyld-trie-symbols/TestDyldTrieSymbols.py b/lldb/test/API/macosx/dyld-trie-symbols/TestDyldTrieSymbols.py
index 6f2f1c5b7cee4..71598e9f15464 100644
--- a/lldb/test/API/macosx/dyld-trie-symbols/TestDyldTrieSymbols.py
+++ b/lldb/test/API/macosx/dyld-trie-symbols/TestDyldTrieSymbols.py
@@ -37,8 +37,8 @@ def test_dyld_trie_symbols(self):
         unstripped_foo_symbols = unstripped_target.FindSymbols("foo")
         self.assertEqual(unstripped_foo_symbols.GetSize(), 1)
 
-        # make sure we can look up the mangled name, demangled base name,
-        # demangled name with argument.
+        # Make sure we can look up the mangled name and the demangled base
+        # name.
         unstripped_Z3pat_symbols = unstripped_target.FindSymbols("_Z3pati")
         self.assertEqual(unstripped_Z3pat_symbols.GetSize(), 1)
         unstripped_pat_symbols = unstripped_target.FindSymbols("pat")


        


More information about the lldb-commits mailing list