[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

Sat Jan 29 00:09:15 PST 2022

paolosev added a comment.

Hi @xujuntwt95329,
Honestly I wasn't thinking to support multithreading with this initial patch so I am not surprised that it doesn't work. You are right, we should add thread information to the messages.
Actually I am a little surprised that the patch still works after all this time (more than one year), and that there have not been small changes that caused merge errors.
I am afraid that manually patching LLDB might not be a sustainable solution. :(

@labath, @jingham 
Given that the debugging feature is being supported also by WebAssembly Micro Runtime <https://github.com/bytecodealliance/wasm-micro-runtime> now, maybe we could work together to finalize an implementation of this patch (or also some other different solution) that will be less intrusive and more acceptable to be merged in LLDB?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78801/new/

https://reviews.llvm.org/D78801