[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

Sat Jan 29 00:24:02 PST 2022

xujuntwt95329 added a comment.

In D78801#3281504 <https://reviews.llvm.org/D78801#3281504>, @paolosev wrote:

> Hi @xujuntwt95329,
> Honestly I wasn't thinking to support multithreading with this initial patch so I am not surprised that it doesn't work. You are right, we should add thread information to the messages.
> Actually I am a little surprised that the patch still works after all this time (more than one year), and that there have not been small changes that caused merge errors.
> I am afraid that manually patching LLDB might not be a sustainable solution. :(
>
> @labath, @jingham 
> Given that the debugging feature is being supported also by WebAssembly Micro Runtime <https://github.com/bytecodealliance/wasm-micro-runtime> now, maybe we could work together to finalize an implementation of this patch (or also some other different solution) that will be less intrusive and more acceptable to be merged in LLDB?

Well, your patch works well with **WebAssembly Micro Runtime (WAMR)** source debugging feature in most cases, I have debugged several wasm applications written in C, C++, Rust and Go, it is really useful !
I'll try to add thread id to `qWasmLocal` message and check if it works.

> I am afraid that manually patching LLDB might not be a sustainable solution. :(

I totally agree with you, currently we ask the users to download llvm-project, apply the patch, and build the customized lldb, it takes a long time. It will be great if this can be merged into upstream !!!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78801/new/

https://reviews.llvm.org/D78801