[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

[Venkata Ramanaiah Nalamothu via Phabricator via lldb-commits]

RamNalamothu created this revision.
RamNalamothu added reviewers: JDevlieghere, teemperor, DavidSpickett, zturner.
RamNalamothu requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Certain commands like 'memory write', 'register read' etc all use
the OptionGroupFormat options but the help usage text for those
options is not customized to those commands.

One such example is:

(lldb) help memory read
	-s <byte-size> ( --size <byte-size> )

  The size in bytes to use when displaying with the selected format.

(lldb) help memory write
	-s <byte-size> ( --size <byte-size> )

  The size in bytes to use when displaying with the selected format.

This patch allows such commands to overwrite the help text for the options
in the OptionGroupFormat group as needed and fixes help text of memory write.

Also, currently the 'memory write' command allows specifying the values when
writing the file contents to memory but the values are actually ignored. This
patch fixes that as well by erroring out when values are specified in such cases.

llvm.org/pr49018.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114448

Files:
  lldb/include/lldb/Interpreter/OptionGroupFormat.h
  lldb/source/Commands/CommandObjectMemory.cpp
  lldb/source/Interpreter/CommandObject.cpp
  lldb/source/Interpreter/OptionGroupFormat.cpp
  lldb/test/API/commands/help/TestHelp.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114448.389227.patch
Type: text/x-patch
Size: 9633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20211123/9022b258/attachment-0001.bin>