[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 14 02:12:29 PDT 2021


mgorny added a comment.

In D108831#3063282 <https://reviews.llvm.org/D108831#3063282>, @labath wrote:

> We don't really want to support adding an arbitrary subset of sub-registers, do we? I am thinking if this could be made simpler if it was all-or-nothing. Like, during the initial pass you could check whether the list contains _any_ subregister, and abort if it does. Then the subsequent pass could assume that all subregisters need to be added...

Sure, that makes sense. Should I update AArch64 too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108831/new/

https://reviews.llvm.org/D108831



More information about the lldb-commits mailing list