[Lldb-commits] [PATCH] D108831: [lldb] [ABI/X86] Add pseudo-registers if missing

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

We don't really want to support adding an arbitrary subset of sub-registers, do we? I am thinking if this could be made simpler if it was all-or-nothing. Like, during the initial pass you could check whether the list contains _any_ subregister, and abort if it does. Then the subsequent pass could assume that all subregisters need to be added...



================
Comment at: lldb/source/Plugins/ABI/X86/ABIX86.h:23
+      std::vector<lldb_private::DynamicRegisterInfo::Register> &regs,
+      bool is64bit);
+
----------------
I think you should be able to get this from the ArchSpec of the process.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108831/new/

https://reviews.llvm.org/D108831