[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

Tue Oct 5 00:55:54 PDT 2021

labath added a comment.

In D110997#3039575 <https://reviews.llvm.org/D110997#3039575>, @mgorny wrote:

> In D110997#3039540 <https://reviews.llvm.org/D110997#3039540>, @labath wrote:
>
>> Why is it important to restore the tty settings? (just asking, I have no clue about how this is supposed to work)
>
> Well, maybe my logic is wrong but the idea is that since LLDB overrides serial port parameters, it should restore them to the original state when it's done with the serial port. Roughly the principle that the program cleans up after itself.

That does not sound unreasonable, though I'm not sure how much is it actually useful. Do you know if its like standard practice when working with serial ports, ttys and stuff?

TTTT, I'm not very happy that we have _any_ tty code inside the ConnectionFileDescriptorPosix class, so I'm not enthusiastic about expanding it. Let's see how the RFC goes first...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110997/new/

https://reviews.llvm.org/D110997