[Lldb-commits] [PATCH] D110997: [lldb] Restore tty attributes on disconnect

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 4 04:06:36 PDT 2021


mgorny added a comment.

In D110997#3039540 <https://reviews.llvm.org/D110997#3039540>, @labath wrote:

> Why is it important to restore the tty settings? (just asking, I have no clue about how this is supposed to work)

Well, maybe my logic is wrong but the idea is that since LLDB overrides serial port parameters, it should restore them to the original state when it's done with the serial port. Roughly the principle that the program cleans up after itself.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110997/new/

https://reviews.llvm.org/D110997



More information about the lldb-commits mailing list